From 712a1ff319e9d2200446b2c8ae5539197bb85d6e Mon Sep 17 00:00:00 2001 From: chreamy Date: Wed, 17 Jan 2024 21:36:44 -0600 Subject: [PATCH 1/4] test --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index b1d8aed..870d116 100644 --- a/README.md +++ b/README.md @@ -144,3 +144,4 @@ connect to other host: list sessions: yarn cli list + \ No newline at end of file From 4b9c7de0313fb24834a92389d8b5a960678e6d67 Mon Sep 17 00:00:00 2001 From: chreamy Date: Wed, 17 Jan 2024 21:55:52 -0600 Subject: [PATCH 2/4] fix: issue #96 --- example.env | 5 ----- tests/cypress.config.js | 8 ++++---- 2 files changed, 4 insertions(+), 9 deletions(-) delete mode 100644 example.env diff --git a/example.env b/example.env deleted file mode 100644 index 03f5ea8..0000000 --- a/example.env +++ /dev/null @@ -1,5 +0,0 @@ -BASE_URL=https://example.com -GOOGLE_CLIENT_ID= -GOOGLE_CLIENT_SECRET= -GITHUB_CLIENT_ID= -GITNUB_CLIENT_SECRET= diff --git a/tests/cypress.config.js b/tests/cypress.config.js index b2bb72e..40f6724 100644 --- a/tests/cypress.config.js +++ b/tests/cypress.config.js @@ -6,8 +6,8 @@ const getConfig = (key, defaultValue) => { return process.env[key] || defaultValue } -const getOrFail = (key) => { - const value = getConfig(key) +const getOrFail = (key, defaultValue=undefined) => { + const value = getConfig(key, defaultValue) if (!value) { throw new Error(`Missing required environment variable ${key}`) } @@ -25,8 +25,8 @@ module.exports = defineConfig({ retries: { runMode: 5, openMode: 5 }, }, env: { - defaultAccount: getOrFail('TESTING_USERNAME'), - defaultPassword: getOrFail('TESTING_PASSWORD'), + defaultAccount: getOrFail('TESTING_USERNAME', 'alex'), + defaultPassword: getOrFail('TESTING_PASSWORD', 'Alex1234'), isCHVersion: true, // google_username: process.env.GOOGLE_USERNAME, // google_password: process.env.GOOGLE_PASSWORD, From af088730e87e571af327e410a74632ba46914766 Mon Sep 17 00:00:00 2001 From: chreamy Date: Wed, 17 Jan 2024 22:02:39 -0600 Subject: [PATCH 3/4] fix: issue #96 --- tests/cypress.config.js | 8 ++++---- tests/package.json | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/cypress.config.js b/tests/cypress.config.js index 40f6724..b2bb72e 100644 --- a/tests/cypress.config.js +++ b/tests/cypress.config.js @@ -6,8 +6,8 @@ const getConfig = (key, defaultValue) => { return process.env[key] || defaultValue } -const getOrFail = (key, defaultValue=undefined) => { - const value = getConfig(key, defaultValue) +const getOrFail = (key) => { + const value = getConfig(key) if (!value) { throw new Error(`Missing required environment variable ${key}`) } @@ -25,8 +25,8 @@ module.exports = defineConfig({ retries: { runMode: 5, openMode: 5 }, }, env: { - defaultAccount: getOrFail('TESTING_USERNAME', 'alex'), - defaultPassword: getOrFail('TESTING_PASSWORD', 'Alex1234'), + defaultAccount: getOrFail('TESTING_USERNAME'), + defaultPassword: getOrFail('TESTING_PASSWORD'), isCHVersion: true, // google_username: process.env.GOOGLE_USERNAME, // google_password: process.env.GOOGLE_PASSWORD, diff --git a/tests/package.json b/tests/package.json index d7a5065..550544c 100644 --- a/tests/package.json +++ b/tests/package.json @@ -5,8 +5,8 @@ "main": "index.js", "license": "MIT", "scripts": { - "test": "cypress run", - "test:open": "cypress open" + "test": "export TESTING_USERNAME=alex && export TESTING_PASSWORD=Alex1234 && cypress run", + "test:open": "export TESTING_USERNAME=alex && export TESTING_PASSWORD=Alex1234 && cypress open" }, "dependencies": { "@testing-library/cypress": "^10.0.1", From 68e922878bb304bedde552444ce39b2d1add7f6c Mon Sep 17 00:00:00 2001 From: "Lin, Hung-Shin" Date: Mon, 29 Jan 2024 10:32:38 +0800 Subject: [PATCH 4/4] Update tests/package.json --- tests/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/package.json b/tests/package.json index 550544c..18332d0 100644 --- a/tests/package.json +++ b/tests/package.json @@ -5,8 +5,8 @@ "main": "index.js", "license": "MIT", "scripts": { - "test": "export TESTING_USERNAME=alex && export TESTING_PASSWORD=Alex1234 && cypress run", - "test:open": "export TESTING_USERNAME=alex && export TESTING_PASSWORD=Alex1234 && cypress open" + "test": "TESTING_USERNAME=alex TESTING_PASSWORD=Alex1234 cypress run", + "test:open": "TESTING_USERNAME=alex TESTING_PASSWORD=Alex1234 cypress open" }, "dependencies": { "@testing-library/cypress": "^10.0.1",