From 917083ad309d3e13234236da643583dbb8ccd8fe Mon Sep 17 00:00:00 2001 From: wancat Date: Sun, 29 Oct 2023 17:26:48 +0800 Subject: [PATCH] fix: remove debugging console log --- app/src/utils/session.js | 1 - packages/file-graph/file.test.js | 1 - packages/file-graph/fileGraph.test.js | 5 ----- packages/file-graph/fileNode.test.js | 9 --------- server/src/api/controllers/commandController.js | 1 - server/src/containers/cli.js | 6 +----- server/src/game/commandHandler.js | 1 - 7 files changed, 1 insertion(+), 23 deletions(-) diff --git a/app/src/utils/session.js b/app/src/utils/session.js index 65c2dba..e659bff 100644 --- a/app/src/utils/session.js +++ b/app/src/utils/session.js @@ -23,7 +23,6 @@ class SessionManager { } setSession(session) { - console.log('Update session:', session) this.session.value = session this.graph.value = new FileGraph(session.graph) this.hints.value = session.hints diff --git a/packages/file-graph/file.test.js b/packages/file-graph/file.test.js index 175ac73..f1f84ce 100644 --- a/packages/file-graph/file.test.js +++ b/packages/file-graph/file.test.js @@ -42,7 +42,6 @@ describe('File', () => { filesToCompare.forEach(({ name, path, answer }) => { test(`${name}: ${path}`, () => { const fileToCompare = new File({ path, type: 'file', discovered: true }) - console.log(fileToCompare) expect(file.contains(fileToCompare)).toBe(answer) }) }) diff --git a/packages/file-graph/fileGraph.test.js b/packages/file-graph/fileGraph.test.js index cff996a..509b33d 100644 --- a/packages/file-graph/fileGraph.test.js +++ b/packages/file-graph/fileGraph.test.js @@ -30,7 +30,6 @@ describe('FileGraph', () => { fileGraph.add(filesToAdd) - console.log(fileGraph.toString()) expect(fileGraph.children.length).toBe(1) expect(fileGraph.children[0].children[0].children.length).toBe(2) }) @@ -76,7 +75,6 @@ describe('FileGraph', () => { fileGraph.remove(filesToRemove) - console.log(fileGraph.toString()) expect(fileGraph.children[0].children[0].children.length).toBe(1) expect(fileGraph.children[0].children[0].children[0].name).toBe('folder1') expect(fileGraph.children[0].children[0].children[0].children.length).toBe( @@ -110,7 +108,6 @@ describe('FileGraph', () => { ] fileGraph.discover(discoverFiles) - console.log(fileGraph.toString()) expect(fileGraph.children[0].children[0].children[0].children.length).toBe( 3 ) @@ -143,7 +140,6 @@ describe('FileGraph', () => { ] fileGraph.add(filesToAdd) - console.log(fileGraph.toString()) const newFiles = [ { @@ -170,7 +166,6 @@ describe('FileGraph', () => { fileGraph.discover(newFiles) - console.log(fileGraph.toString()) expect(fileGraph.children[0].children[0].children.length).toBe(2) expect(fileGraph.children[0].children[0].children[0].children.length).toBe( 3 diff --git a/packages/file-graph/fileNode.test.js b/packages/file-graph/fileNode.test.js index 3413dc5..94b6c4d 100644 --- a/packages/file-graph/fileNode.test.js +++ b/packages/file-graph/fileNode.test.js @@ -12,14 +12,8 @@ function mergeTest(files1, files2, expectedFiles) { const node2 = createNodeFromFiles(files2) const expectedNode = createNodeFromFiles(expectedFiles) - console.log('node1', node1.toString()) - console.log('node2', node2.toString()) - console.log('expected', expectedNode.toString()) - node1.merge(node2) - console.log('after-merged', node1.toString()) - expect(node1.toString()).toBe(expectedNode.toString()) } @@ -103,7 +97,6 @@ describe('FileNode', () => { expect(rootNode.children.length).toBe(2) expect(rootNode.children[1].children.length).toBe(1) - console.log(rootNode.toString()) }) test('adds nested children to the tree with makeParents option', () => { @@ -116,7 +109,6 @@ describe('FileNode', () => { rootNode.addChild(file, { makeParents: true }) - console.log(rootNode.toString()) let currentNode = rootNode for (let i = 0; i < 5; i += 1) { expect(currentNode.children.length).toBe(1) @@ -279,7 +271,6 @@ test('load nested fileNode', () => { const node = new FileNode(data) - console.log(node.toString()) expect(node.children.length).toBe(2) expect(node.children[1].children.length).toBe(1) expect(node.children[1].children[0].children.length).toBe(1) diff --git a/server/src/api/controllers/commandController.js b/server/src/api/controllers/commandController.js index f3af3d7..2435176 100644 --- a/server/src/api/controllers/commandController.js +++ b/server/src/api/controllers/commandController.js @@ -5,7 +5,6 @@ import { pushToSession } from '../socket.js' const commandCompleteCallbacks = new Map() export async function newCommand(req, res) { - console.log('new command:', req.body) const { command, pwd, output, error, ...additionalData } = req.body if (!command) { diff --git a/server/src/containers/cli.js b/server/src/containers/cli.js index 0bdedbb..dc4640a 100644 --- a/server/src/containers/cli.js +++ b/server/src/containers/cli.js @@ -10,16 +10,12 @@ function sanitizeId(id) { export function checkFile(id, file) { return new Promise((resolve, reject) => { const cmd = buildFileCheckCmd(file) - console.log(cmd) // WARNING: This is vulnerable to command injection execFile( 'docker', ['exec', sanitizeId(id), ...cmd], { timeout: 1000 }, - (error, stdout, stderr) => { - if (stderr) console.log('error', error) - if (stdout) console.log('stdout', stdout) - if (error) console.log('error', error) + (error) => { const exists = !error if (exists === file.exists) { resolve(true) diff --git a/server/src/game/commandHandler.js b/server/src/game/commandHandler.js index aec371a..7ee78c8 100644 --- a/server/src/game/commandHandler.js +++ b/server/src/game/commandHandler.js @@ -72,7 +72,6 @@ export default class CommandHandler extends SessionHandler { if (files.length === 0) { return true } - console.log('checkFiles', files) try { const checks = await Promise.all( files.map((f) => checkFile(this.session.containerId, f))