refactor: add getOrCreateSession to simplify process

server/src/api/controllers/sessionController.js

@@ -1,5 +1,8 @@
 import { Session } from '@linux-odyssey/models'
-import { createNewSession } from '../../game/sessionManager.js'
+import {
+  createNewSession,
+  getOrCreateActiveSession,
+} from '../../game/sessionManager.js'
 
 function sessionSummary(session) {
   return {
@@ -82,3 +85,14 @@ export async function deleteSessionById(req, res) {
     res.status(500).json({ message: err.message })
   }
 }
+
+export async function getActiveSession(req, res) {
+  const { quest_id } = req.body
+  try {
+    const session = await getOrCreateActiveSession(req.user, quest_id)
+    res.json(sessionDetail(session))
+  } catch (err) {
+    console.error(err)
+    res.status(500).json({ message: err.message })
+  }
+}

server/src/api/routes/sessions.js

@@ -5,6 +5,7 @@ const router = Router()
 
 router.get('/', sessionController.getSessionList)
 router.post('/', sessionController.createSession)
+router.post('/active', sessionController.getActiveSession)
 router.get('/:id', sessionController.getSessionById)
 router.delete('/:id', sessionController.deleteSessionById)
 

server/src/game/sessionManager.js

@@ -10,11 +10,13 @@ async function deactivateSessions(user, quest) {
   })
   return Promise.all(
     sessions.map((session) => {
-      return deleteContainer(session.containerId).then(() => {
-        session.status = 'inactive'
-        session.containerId = null
-        return session.save()
-      })
+      return deleteContainer(session.containerId)
+        .catch(console.error)
+        .finally(() => {
+          session.status = 'inactive'
+          session.containerId = null
+          return session.save()
+        })
     })
   )
 }
@@ -48,3 +50,15 @@ export async function createNewSession(user, questId) {
   await session.save()
   return session
 }
+
+export async function getOrCreateActiveSession(user, questId) {
+  const session = await Session.findOne({
+    user,
+    quest: questId,
+    status: 'active',
+  })
+  if (session) {
+    return session
+  }
+  return createNewSession(user, questId)
+}