refactor: fix file condition checks

packages/models/src/condition.ts

@@ -2,8 +2,8 @@ import { Schema } from 'mongoose'
 
 export interface IFileCondition {
   path: string
-  type?: string
+  type: string
-  exists?: boolean
+  exists: boolean
 }
 
 export interface ICondition {

packages/models/src/index.ts

@@ -5,6 +5,7 @@ export { Quest, IQuest } from './quest.js'
 export { Session, ISession } from './session.js'
 export { Command, ICommand } from './command.js'
 export { UserProfile, IUserProfile } from './userProfile.js'
+export { IFileCondition, ICondition } from './condition.js'
 
 export default async function connectDB(uri: string) {
   const db = await mongoose.connect(uri)

packages/utils/package.json

@@ -8,6 +8,6 @@
   "license": "MIT",
   "scripts": {
     "build": "tsc",
-    "watch": "tsc -w"
+    "dev": "tsc -w"
   }
 }

packages/utils/src/commands.ts

@@ -1,23 +1,17 @@
-const fileTypes = {
+import type { IFileCondition } from '@linux-odyssey/models'
-  file: '-f',
-  folder: '-d',
-  link: '-L',
-  socket: '-S',
-  unknown: '-e',
-}
 
-export type FileType = keyof typeof fileTypes
+const fileTypes = new Map([
-
+  ['file', '-f'],
-export type File = {
+  ['folder', '-d'],
-  path: string
+  ['link', '-L'],
-  type: FileType
+  ['socket', '-S'],
-}
+])
 
 function sanitizePath(path: string): string {
   return path.replace(/[^a-zA-Z0-9._/-]/g, '')
 }
 
-export function buildFileCheckCmd(file: File): string[] {
+export function buildFileCheckCmd(file: IFileCondition): string[] {
   const { path, type } = file
-  return ['test', fileTypes[type] || '-e', sanitizePath(path)]
+  return ['test', fileTypes.get(type) || '-e', sanitizePath(path)]
 }

server/src/containers/cli.ts

@@ -1,13 +1,14 @@
 import { execFile } from 'child_process'
 
 import { buildFileCheckCmd } from '@linux-odyssey/utils'
+import type { IFileCondition } from '@linux-odyssey/models'
 
-function sanitizeId(id) {
+function sanitizeId(id: string) {
   return id.replace(/[^a-zA-Z0-9]/g, '')
 }
 
 // eslint-disable-next-line import/prefer-default-export
-export function checkFile(id, file) {
+export function checkFile(id: string, file: IFileCondition) {
   return new Promise((resolve, reject) => {
     const cmd = buildFileCheckCmd(file)
     // WARNING: This is vulnerable to command injection