From 119f8c552aca7a4d02a3349aa01c1f029431654d Mon Sep 17 00:00:00 2001
From: Justin Lin <wancat@wancat.cc>
Date: Fri, 9 Oct 2026 23:23:02 +1100
Subject: [PATCH] refactor: replace svg rect with html button

Only use svg to draw lines
---
 app/src/components/QuestMap.vue | 206 ++++++++++++--------------------
 1 file changed, 78 insertions(+), 128 deletions(-)

diff --git a/app/src/components/QuestMap.vue b/app/src/components/QuestMap.vue
index 3956b14..93d203d 100644
--- a/app/src/components/QuestMap.vue
+++ b/app/src/components/QuestMap.vue
@@ -11,49 +11,11 @@ const { t, locale } = useI18n()
 const store = useUserProfile()
 const toast = useToast()
 
-const svgWidth = ref(window.innerWidth)
-const svgHeight = ref(window.innerHeight)
-
 const marginX = 120
 const marginY = 120
 
 const nodeWidth = 160
 const nodeHeight = 50
-const maxTextWidth = nodeWidth - 20
-const fontSize = 16
-const maxLines = 2
-
-// Approximate glyph width: wide (CJK etc.) chars take a full em, others about half
-function charWidth(ch: string) {
-  return ch.charCodeAt(0) > 0x2e80 ? fontSize : fontSize * 0.55
-}
-
-function textWidth(s: string) {
-  return [...s].reduce((w, ch) => w + charWidth(ch), 0)
-}
-
-// SVG text does not wrap, so split the title into lines that fit the node
-function wrapTitle(title: string): string[] {
-  const lines: string[] = []
-  let current = ''
-  // Keep whole words together for spaced languages; CJK splits per character
-  const tokens = title.match(/[⺀-￿]|\S+\s*/g) ?? []
-  for (const token of tokens) {
-    if (current && textWidth((current + token).trimEnd()) > maxTextWidth) {
-      lines.push(current.trimEnd())
-      current = ''
-    }
-    current += token
-  }
-  if (current) lines.push(current.trimEnd())
-
-  if (lines.length <= maxLines) return lines
-  const kept = lines.slice(0, maxLines)
-  let last = kept[maxLines - 1]
-  while (last && textWidth(last + '…') > maxTextWidth) last = last.slice(0, -1)
-  kept[maxLines - 1] = last + '…'
-  return kept
-}
 
 const opened = ref<Node | null>(null)
 type Node = {
@@ -82,14 +44,18 @@ const dragStartY = ref(0)
 const offsetX = ref(0)
 const offsetY = ref(0)
 
-function startDrag(event: MouseEvent) {
+function startDrag(event: PointerEvent) {
   isDragging.value = true
   dragStartX.value = event.clientX - offsetX.value
   dragStartY.value = event.clientY - offsetY.value
 }
 
-function drag(event: MouseEvent) {
+function drag(event: PointerEvent) {
   if (!isDragging.value) return
+  // Capture only once dragging starts so plain clicks still reach the node buttons
+  const el = event.currentTarget as HTMLElement
+  if (!el.hasPointerCapture(event.pointerId))
+    el.setPointerCapture(event.pointerId)
   offsetX.value = event.clientX - dragStartX.value
   offsetY.value = event.clientY - dragStartY.value
 }
@@ -111,10 +77,8 @@ async function computeGraphData() {
       id: node.id,
       title: node.title,
       x: marginX * node.layer * 2,
-      y:
-        marginY * node.index -
-        (marginX * dag.getLayer(node.id)) / 2 +
-        svgHeight.value / 2,
+      // Centered on 0; the world container is anchored at the viewport's vertical center
+      y: (node.index - (dag.getLayer(node.id) + 1) / 2) * marginY,
       completed: store.progress[node.id]?.completed || false,
       unlocked: node.requirements.every(
         (req: string) => store.progress[req]?.completed
@@ -159,14 +123,10 @@ watch(locale, () => {
   computeGraphData()
 })
 
-const curvedPath = computed(() => {
+const edgePath = computed(() => {
   return (source: Node, target: Node) => {
-    // const dx = target.x - source.x
-    // const dy = target.y - source.y
-    // const dr = Math.sqrt(dx * dx + dy * dy)
-    const dr = 0
-    const sweep = target.index > source.index ? 0 : 1 // Determines if the arc should curve up or down based on node index
-    return `M${source.x},${source.y}A${dr},${dr} 0 0,${sweep} ${target.x},${target.y}`
+    const mx = (source.x + target.x) / 2
+    return `M${source.x},${source.y}C${mx},${source.y} ${mx},${target.y} ${target.x},${target.y}`
   }
 })
 
@@ -196,58 +156,44 @@ const edgeStyle = computed(() => {
       >
         {{ t('quest_map.intro') }}
       </h1>
-      <svg
-        :width="svgWidth"
-        :height="svgHeight"
-        class="absolute"
-        @mousedown="startDrag"
-        @mousemove="drag"
-        @mouseup="endDrag"
-        @mouseleave="endDrag"
+      <div
+        class="absolute inset-0 overflow-hidden select-none"
+        :class="isDragging ? 'cursor-grabbing' : 'cursor-grab'"
+        style="touch-action: none"
+        @pointerdown="startDrag"
+        @pointermove="drag"
+        @pointerup="endDrag"
+        @pointercancel="endDrag"
       >
-        <g :transform="`translate(${offsetX}, ${offsetY})`">
-          <g
-            v-for="edge in graphData.edges"
-            :key="`${edge.source.id}-${edge.target.id}`"
-          >
+        <div
+          class="absolute top-1/2 left-0"
+          :style="{ transform: `translate(${offsetX}px, ${offsetY}px)` }"
+        >
+          <svg class="absolute overflow-visible pointer-events-none">
             <path
-              :d="curvedPath(edge.source, edge.target)"
+              v-for="edge in graphData.edges"
+              :key="`${edge.source.id}-${edge.target.id}`"
+              :d="edgePath(edge.source, edge.target)"
               :class="['edge', edgeStyle(edge)]"
             />
-          </g>
-          <g
+          </svg>
+          <button
             v-for="node in graphData.nodes"
             :key="node.id"
+            type="button"
+            :class="['node', nodeStyle(node)]"
+            :style="{
+              left: `${node.x - nodeWidth / 2}px`,
+              top: `${node.y - nodeHeight / 2}px`,
+              width: `${nodeWidth}px`,
+              height: `${nodeHeight}px`,
+            }"
             @click="handleNodeClick(node)"
           >
-            <rect
-              :x="node.x - nodeWidth / 2"
-              :y="node.y - nodeHeight / 2"
-              :width="nodeWidth"
-              :height="nodeHeight"
-              rx="10"
-              ry="10"
-              :class="['node', nodeStyle(node)]"
-            />
-            <text
-              :x="node.x"
-              :y="node.y"
-              text-anchor="middle"
-              dominant-baseline="central"
-              :class="['node-text', nodeStyle(node)]"
-            >
-              <tspan
-                v-for="(line, i) in wrapTitle(node.title)"
-                :key="i"
-                :x="node.x"
-                :dy="i === 0 ? `${-(wrapTitle(node.title).length - 1) * 0.6}em` : '1.2em'"
-              >
-                {{ line }}
-              </tspan>
-            </text>
-          </g>
-        </g>
-      </svg>
+            <span class="line-clamp-2">{{ node.title }}</span>
+          </button>
+        </div>
+      </div>
       <QuestIntro
         :questTitle="opened.title"
         :questId="opened.id"
@@ -260,45 +206,49 @@ const edgeStyle = computed(() => {
 </template>
 
 <style scoped>
-svg {
-  overflow: visible;
-}
-
 .node {
-  &.completed {
-    fill: #6cf76c;
-  }
-  &.unlocked {
-    fill: #8c8c92;
-  }
-  &.locked {
-    fill: #505050;
-  }
-}
-
-.node-text {
+  position: absolute;
+  display: flex;
+  align-items: center;
+  justify-content: center;
+  padding: 0 0.5rem;
+  text-align: center;
+  border-radius: 10px;
   cursor: pointer;
-  &.completed {
-    fill: #1d1d1d;
-  }
-  &.unlocked {
-    fill: #ffffff;
-  }
-  &.locked {
-    fill: #a0a0a0;
-  }
+  transition:
+    filter 0.15s,
+    box-shadow 0.15s;
+}
+.node:hover {
+  filter: brightness(1.15);
+}
+.node:focus-visible {
+  outline: none;
+  box-shadow: 0 0 0 3px #00ff00;
+}
+.node.completed {
+  background-color: #6cf76c;
+  color: #1d1d1d;
+}
+.node.unlocked {
+  background-color: #8c8c92;
+  color: #ffffff;
+}
+.node.locked {
+  background-color: #505050;
+  color: #a0a0a0;
 }
 
 .edge {
   stroke-width: 3;
   fill: none;
-  &.unlocked {
-    stroke: #adadb5;
-    stroke-dasharray: none;
-  }
-  &.locked {
-    stroke: #454552;
-    stroke-dasharray: 5, 5;
-  }
+}
+.edge.unlocked {
+  stroke: #adadb5;
+  stroke-dasharray: none;
+}
+.edge.locked {
+  stroke: #454552;
+  stroke-dasharray: 5, 5;
 }
 </style>